Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scrollUntilVisible and scrollUntilTapable not working correctly #622

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: scrollUntilVisible and scrollUntilTapable not working correctly #622

merged 1 commit into from
Nov 15, 2023

Conversation

felix-barz-brickmakers
Copy link
Contributor

Fixes #621

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 10, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: felix-barz-brickmakers / name: Felix Barz (Brickmakers) (d9fe636)

@KazuCocoa
Copy link
Member

KazuCocoa commented Nov 10, 2023 •
edited
Loading

Thank you. Could you sign the CLA? @felix-barz-brickmakers

KazuCocoa
KazuCocoa approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

(Waiting for the CLA sign)

@felix-barz-brickmakers
Copy link
Contributor Author

I am working on getting the CLA through, but it might take a few days longer. Sorry for the delay.

@felix-barz-brickmakers
Copy link
Contributor Author

Done

@KazuCocoa KazuCocoa merged commit 4073fbc into appium:main Nov 15, 2023
4 checks passed
@thuonglai
Copy link
Contributor

I just tested with version 2.2.2. And scrollUntilVisible working not correct

@KazuCocoa
Copy link
Member

Could you create a new issue and details description?

@thuonglai
Copy link
Contributor

@KazuCocoa I created issue #624 for it.

@felix-barz-brickmakers
Copy link
Contributor Author

FYI: For my usecase, the fix did work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scrollUntilVisible and scrollUntilTappable are broken.
3 participants
@felix-barz-brickmakers @KazuCocoa @thuonglai