Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: leftover portforward #625

Merged
merged 9 commits into from
Nov 23, 2023
Merged

fix: leftover portforward #625

merged 9 commits into from
Nov 23, 2023

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Nov 21, 2023 •
edited
Loading

I found leftover ports in #617 , we should fix

  • Remove the previous port in the retrial
  • Remove the current port forward in the deleteSession

For example, current method to do the port forward leftover the used ports, which is bad.

% adb  forward --list
D0AA002182JC0202126 tcp:8200 tcp:6790
D0AA002182JC0202126 tcp:41323 tcp:41323

% adb  forward --list
D0AA002182JC0202126 tcp:8200 tcp:6790
D0AA002182JC0202126 tcp:41323 tcp:41323

this will be:...

% adb  forward --list
D0AA002182JC0202126 tcp:8200 tcp:6790
D0AA002182JC0202126 tcp:39947 tcp:39947

% adb  forward --list

@KazuCocoa KazuCocoa changed the title Remove portforward fix: leftover portforward Nov 21, 2023
@KazuCocoa KazuCocoa marked this pull request as ready for review November 22, 2023 07:45
@KazuCocoa
Copy link
Member Author

lts see how this will be

@KazuCocoa KazuCocoa merged commit 1a74e04 into main Nov 23, 2023
8 checks passed
@KazuCocoa KazuCocoa deleted the remove-portforward branch November 23, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KazuCocoa