feat: update Python recorder code #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eglitise
added
enhancement
KazuCocoa
approved these changes
Nov 2, 2023
| } | ||
|
|
||
| codeFor_background (varNameIgnore, varIndexIgnore, timeout) { | ||
| return `driver.background_app(${timeout})`; | ||
| } | ||
|
|
||
| codeFor_activateApp (varNameIgnore, varIndexIgnore, app) { | ||
| return `driver.activate_app('${app}')`; |
There was a problem hiding this comment.
I wondered if this command ideally needs to be mobile: command -> https://github.com/appium/appium-uiautomator2-driver?tab=readme-ov-file#mobile-activateapp
but for now, looks good to me. the argument name should be changed for mobile command for android/ios and other drivers
There was a problem hiding this comment.
I think this is fine, because the implementation in the Python client calls mobile: activateApp anyway: https://github.com/appium/python-client/blob/master/appium/webdriver/extensions/applications.py#L187
shiva-guntoju
pushed a commit
to shiva-guntoju/appium-inspector
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the recorder-generated code for the Python client:
activateApp,terminateApp,sendSMS)executeScriptimplementation