Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor #1447

Merged
merged 8 commits into from
May 1, 2024
Merged

chore: refactor #1447

merged 8 commits into from
May 1, 2024

Conversation

eglitise
Copy link
Collaborator

@eglitise eglitise commented May 1, 2024

This PR continues the preparation for migrating to Vite, and primarily changes many file locations:

  • add a new assets directory in renderer, and move images, locales and stylesheets directories to it
  • move main.js to main directory
  • merge Root.jsx and routes.jsx (originally I only moved Root.jsx to its parent directory, but merging it with routes.jsx further improved clarity)
  • add a new src directory in renderer and move all renderer contents to it, except HTML entrypoint files

Browser and Electron versions were tested to still work fine.

@github-actions github-actions bot added chore Internal changes not visible to the user documentation Improvements or additions to documentation labels May 1, 2024
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me! we'll want to double check the CrowdIn integration works without issue after we merge.

@eglitise
Copy link
Collaborator Author

eglitise commented May 1, 2024

I think it should be fine, since the path for translation files was only defined in one file.

@eglitise eglitise merged commit 5155a98 into appium:main May 1, 2024
7 checks passed
@eglitise eglitise deleted the vite-phase-2 branch May 1, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Internal changes not visible to the user documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants