Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix support for Attach to Session for LambdaTest server #1656

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Delta456
Copy link
Contributor

@Delta456 Delta456 commented Sep 5, 2024

Fixes #1652

Thanks to @eglitise for his help!

More detailed info is explained in #1369 (comment)

Copy link

linux-foundation-easycla bot commented Sep 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Delta456 / name: Swastik Baranwal (366075b)

@github-actions github-actions bot added the chore Internal changes not visible to the user label Sep 5, 2024
@eglitise
Copy link
Collaborator

eglitise commented Sep 5, 2024

Thank you! I assume you've tested this fix and confirmed it works with your sessions :)
Could you also please sign the CLA?

@Delta456
Copy link
Contributor Author

Delta456 commented Sep 5, 2024

Thank you! I assume you've tested this fix and confirmed it works with your sessions :) Could you also please sign the CLA?

It should be signed in a few hours.

@Delta456
Copy link
Contributor Author

Delta456 commented Sep 5, 2024

The CLA has been approved. Please merge, if possible do a release with this fix 😅

@KazuCocoa KazuCocoa merged commit 192a14b into appium:main Sep 6, 2024
6 checks passed
@Delta456 Delta456 deleted the fix_lt_attach_to_session branch September 6, 2024 03:22
@eglitise eglitise added size:S contribution size: S size:XS contribution size: XS and removed size:S contribution size: S labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Internal changes not visible to the user size:XS contribution size: XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cannot use Attach to Session when using LambdaTest cloud provider
5 participants