chore: Refactor the background endpoint implementation #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
imurchie
reviewed
Sep 6, 2019
lib/commands/general.js
Outdated
| const selectEndpoint = (timeoutSeconds) => { | ||
| if (!util.hasValue(timeoutSeconds)) { | ||
| endpoint = homescreen; | ||
| } if (!isNaN(timeoutSeconds)) { |
There was a problem hiding this comment.
Not sure what this line is doing...
There was a problem hiding this comment.
it check if timeoutSeconds is some random string or other object, which cannot be parsed to a number
There was a problem hiding this comment.
where do you want to see it?
There was a problem hiding this comment.
there was missing else. Should look better now
There was a problem hiding this comment.
Ah! That makes sense, then. Thanks.
6 tasks
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to keep the approach where
secondsargument is passed to this endpoint like in Android to avoid unnecessary confusion for different clients.The final rules will be: