Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands for file movement, device time, strings, and app lifecycle #129

Merged
merged 3 commits into from
Sep 14, 2016

Conversation

imurchie
Copy link
Contributor

@imurchie imurchie commented Sep 9, 2016

No description provided.

@@ -44,5 +45,22 @@ commands.getWindowSize = async function (windowHandle = 'current') {
return await this.executeAtom('get_window_size', []);
};

commands.getDeviceTime = iosCommands.general.getDeviceTime;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean I could have done this https://github.com/appium/appium-xcuitest-driver/blob/master/lib/commands/gesture.js#L42-L50 with just
commands.isDrag = iosCommands.gestures.isDrag; ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is a method that exists in appium-ios-driver, and is in a file in the /commands/ tree, then yes. They are exported here: https://github.com/appium/appium-ios-driver/blob/master/lib/commands/index.js#L30-L47

@yaphatak
Copy link
Contributor

yaphatak commented Sep 9, 2016

Do check-in this sooner :). Looks like lot of change in driver.js

@imurchie
Copy link
Contributor Author

The changes to driver.js are just pulling stuff out into start and stop, which the ios driver methods require.

@yaphatak
Copy link
Contributor

Yes. I see that. Sooner that goes in I can merge some of changes I have been working on in same file :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants