Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update the default timeout for the recent webview detection #2337

Merged
merged 2 commits into from
Mar 8, 2024
Merged

fix: Update the default timeout for the recent webview detection #2337

merged 2 commits into from
Mar 8, 2024

Conversation

mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach commented Mar 5, 2024 •
edited
Loading

90 seconds is definitely too much for that by default.

@mykola-mokhnach
Copy link
Contributor Author

@KazuCocoa Could you please try it with a real device? What is the average time needed for this API to pick a web view for real devices?

@mykola-mokhnach mykola-mokhnach changed the title fix: Update the timeout for the recent webview detection fix: Update the default timeout for the recent webview detection Mar 6, 2024
@KazuCocoa
Copy link
Member

looks good. tested with safari quickly. Let me test with webview app and a few more tomorrow

@eglitise
Copy link
Contributor

eglitise commented Mar 6, 2024

From what I understand, this removes the approach of clicking the refresh button when using Safari in simulators. I guess it was rather specific, but does the current approach still work for that case?

KazuCocoa
KazuCocoa approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with a real device. Safari, and with autoWebView with a webview app

@mykola-mokhnach
Copy link
Contributor Author

From what I understand, this removes the approach of clicking the refresh button when using Safari in simulators. I guess it was rather specific, but does the current approach still work for that case?

The main change is the timeout tuning. The Refresh button thing never worked anyway and was not stable.

@mykola-mokhnach mykola-mokhnach merged commit 8d7750c into appium:master Mar 8, 2024
18 checks passed
@mykola-mokhnach mykola-mokhnach deleted the webview_detect branch March 8, 2024 07:36
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
@semantic-release-bot
chore(release): 7.3.0 [skip ci]
fa5d8af 
## [7.3.0](v7.2.0...v7.3.0) (2024-03-08)

### Features

* Video recording using native XCTest backend ([#2339](#2339)) ([e17e88b](e17e88b))

### Bug Fixes

* Update the default timeout for the recent webview detection ([#2337](#2337)) ([8d7750c](8d7750c))

### Miscellaneous Chores

* bump typescript ([40d5f5d](40d5f5d))
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

🎉 This PR is included in version 7.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@eglitise eglitise Awaiting requested review from eglitise

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mykola-mokhnach @KazuCocoa @eglitise