Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add updatedWDABundleIdSuffix for usePreinstalledWDA usage #2358

Merged
merged 36 commits into from
Mar 26, 2024

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Mar 26, 2024

This must be after #2354 to use proper WDA deps version.

This change is based on #2354 to use appium/WebDriverAgent#871

Current master (without doNotAddXctrunnerSuffix)

[XCUITestDriver@a2f8 (57c6dc47)] Launching WebDriverAgent on the device without xcodebuild
[XCUITestDriver@a2f8 (57c6dc47)] Executing xcrun devicectl device process launch --device 00008020-000E5CDA0A23002E com.kazucocoa.WebDriverAgentRunner.xctrunner --terminate-existing --environment-variables '{"USE_PORT":"8100","WDA_PRODUCT_BUNDLE_IDENTIFIER":"com.kazucocoa.WebDriverAgentRunner.xctrunner"}'

With doNotAddXctrunnerSuffix

[XCUITestDriver@de9e (d4424fca)] Launching WebDriverAgent on the device without xcodebuild
[XCUITestDriver@de9e (d4424fca)] Executing xcrun devicectl device process launch --device 00008020-000E5CDA0A23002E com.kazucocoa.WebDriverAgentRunner --terminate-existing --environment-variables '{"USE_PORT":"8100","WDA_PRODUCT_BUNDLE_IDENTIFIER":"com.kazucocoa.WebDriverAgentRunner"}'

[update] updatedWDABundleIdSuffix will handle the suffix instead.

@KazuCocoa KazuCocoa changed the title feat: add doNotAddXctrunnerSuffix for usePreinstalledWDA usage feat: add updatedWDABundleIdSuffix for usePreinstalledWDA usage Mar 26, 2024
Default `appium:updatedWDABundleId` takes care of the hidden automatic suffix, `.xctrunner`, by Xcode, but it could break the non- `.xctrunner` package name case.
`appium:doNotAddXctrunnerSuffix` capability will prevent adding the suffix.
A session launches preinstalled bundle id that does not include `.xctrunner` with `"appium:doNotAddXctrunnerSuffix": true`.
XCUITest driver takes care of the hidden automatic suffix, `.xctrunner`, by Xcode by default with `appium:updatedWDABundleIdSuffix`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XCUITest driver automatically adds the .xctrunner suffix to the provided bundle identifier unless a different suffix is specified by the appium:updatedWDABundleIdSuffix capability. If the value is an empty string then no suffix will be added to the provided bundle identifier.

@mykola-mokhnach
Copy link
Contributor

Please bump WDA before merging this PR

Base automatically changed from add-launch to master March 26, 2024 16:07
@KazuCocoa KazuCocoa merged commit b8291cb into master Mar 26, 2024
18 checks passed
@KazuCocoa KazuCocoa deleted the donot-add-xctrunner branch March 26, 2024 20:14
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
## [7.6.0](v7.5.5...v7.6.0) (2024-03-26)

### Features

* add updatedWDABundleIdSuffix for usePreinstalledWDA usage ([#2358](#2358)) ([b8291cb](b8291cb))
Copy link
Contributor

🎉 This PR is included in version 7.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants