Make mobile gestures more user friendly #399
Conversation
lib/commands/gesture.js
Outdated
| if (gestures.length !== candidates.length) { | ||
| return false; | ||
| } | ||
| for (let i in gestures) { |
There was a problem hiding this comment.
we don't use for ... in, we use for ... of; or in the case of wanting the index, just a regular for loop:
for (let i = 0; i < gestures.length; i++) {There was a problem hiding this comment.
i also wonder if you could wrap this whole for block in a try/catch; if you get an exception anywhere in here it must mean they are different as well, right?
lib/commands/gesture.js
Outdated
| } | ||
|
|
||
| function gesturesChainToString (gestures) { | ||
| return _.map(gestures, (item) => { |
There was a problem hiding this comment.
no need to use _.map, can just do:
return gestures.map((item) => {
|
@jlipps how it would be better to export these helper functions, so they are available for unit testing? |
| @@ -24,21 +24,102 @@ commands.click = async function (el) { | |||
| } | |||
| }; | |||
|
|
|||
| function isSameGestures (gestures, candidates) { | |||
There was a problem hiding this comment.
yeah, you can just make this helpers.isSameGestures = ...
|
I think @imurchie should have the chance to weigh in, otherwise it looks ready to merge |
mykola-mokhnach
force-pushed
the
supported_gestures
branch
from
9215ebd to
41daf0f
Compare
mykola-mokhnach
force-pushed
the
supported_gestures
branch
from
41daf0f to
46695ef
Compare
lib/commands/gesture.js
Outdated
| @@ -24,21 +24,104 @@ commands.click = async function (el) { | |||
| } | |||
| }; | |||
|
|
|||
| helpers.isSameGestures = function (gestures, candidates) { | |||
There was a problem hiding this comment.
Since this function does not use anything on the driver object, I would rather see it (and the gesturesChainToString function) as a standalone function, which is then exported from this file for testing purposes.
There was a problem hiding this comment.
can you please suggest on how to properly import these functions from unit tests in such case?
There was a problem hiding this comment.
// lib/commands/gesture.js
// ...
function isSameGestures (gestures, candidates) {
// ...
}
// ...
Object.assign(extensions, helpers, commands);
export { extensions, helpers, commands, isSameGestures };
export default extensions;
// test/unit/commands/gesture-specs.js
// ...
import { isSameGestures } from '../../../lib/commands/gesture';
// ...There was a problem hiding this comment.
thanks. That's exactly what I needed
|
Published in |
Trying to decrease the count of GitHub issues about iOS gestures and make the stuff more user-frindly in general.