make nativeWebTap a setting in addition to a cap #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users often find themselves in a situation where they want to use nativeWebTap in some cases and the regular javascript actions in other cases. This is a perfect example of what the settings API was invented to handle. So handle it using the settings API!
|
looks like this also accidentally included package-lock.json, but apparently we are meant to check these in anyhow, so maybe that's ok |
imurchie
approved these changes
Jun 16, 2017
It could be, yes. I'm not sure how high-priority it is given our lower level of support for that driver. |
|
published in |
4 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
users often find themselves in a situation where they want to use
nativeWebTap in some cases and the regular javascript actions
in other cases. This is a perfect example of what the settings
API was invented to handle. So handle it using the settings API!