feat: Add a broadcast service to receive the clipboard content #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Nov 15, 2019
There was a problem hiding this comment.
Thanks, great 🎉
The result was expected after calling set clipboard via UIA2 👍
$ adb shell am broadcast -a io.appium.settings.clipboard.get
Broadcasting: Intent { act=io.appium.settings.clipboard.get flg=0x400000 }
Broadcast completed: result=-1, data="happy testing"
And update readme, too?
|
@KazuCocoa Updated the readme |
KazuCocoa
approved these changes
Nov 15, 2019
app/build.gradle
Outdated
| @@ -5,7 +5,7 @@ android { | |||
| buildToolsVersion '28.0.3' | |||
|
|
|||
| defaultConfig { | |||
| minSdkVersion 17 | |||
| minSdkVersion 19 | |||
There was a problem hiding this comment.
Does this change need in this update?
There was a problem hiding this comment.
yes, the encoding stuff needs Appium settings to be at API 19, which is fine for us (it's Android 4.4)
There was a problem hiding this comment.
I've changed the code to still support API 17. The market share there is about 1.5-2%, but whatever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step would be to change ADB to set Appium Settings as default IME before getting the clipboard content for Android Q+
See appium/appium#13466 for more details