fix: remove appiumVersion from MobileCapabilityType #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@enriquegh Could you please sign the CLA? |
|
Done! @mykola-mokhnach |
enriquegh
changed the title
|
This is not quite what I wanted to do... I will try to fix it |
enriquegh
force-pushed
the
appiumVersion-removal
branch
from
73ddcbf
to
17a66e7
Compare
mykola-mokhnach
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
The capability
appiumVersionis a Sauce specific capability.This should not be included in the Java bindings since Appium does not do anything with this capability and should be handled either manually by the user or via some other third party tool.
This fixes this being included on the Appium Java client.