-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #203 #210
Fix #203 #210
Conversation
After the coversation with @Simon-Kaz I'm going to improve the new annotation @WithTimeout(time = 20, unit = TimeUnit.SECONDS) |
oh I like this. Definitely makes it easier to define tests. Will merge when @TikhomirovSergey and @Simon-Kaz gives thumbs-up |
I've finished |
...and unused import
👍 Going to use this a lot :) |
super. |
I used What I did in the driver wrapper class is like below. public void setTimeOut(long implicitlyWaitTimeOut, TimeUnit timeUnit) {
timeOutDuration.setTime(implicitlyWaitTimeOut, timeUnit);
getDriver().manage().timeouts().implicitlyWait(timeOutDuration.getTime(), timeOutDuration.getTimeUnit());
getDriver().manage().timeouts().pageLoadTimeout(timeOutDuration.getTime(), timeOutDuration.getTimeUnit());
} here below is the log when trying to finding an element for accessibility named "我的". In the log, there are two timeouts requested. one is using
Could you tell me why timeout 0 is requested instead of my custom set (10)? and what is the correct way doing global wait timeout for all PageObjects? |
Change list:
Use case:
Use case:
If it is extramally needed to change default time for the waiting of elements the following is possible: