#283 fix: Improvement of AppiumDriverLocalService for the multithreading. #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Multithreading test.
Also improvement of ThreadSafetyTest
+ Multithreading test improvement.
|
@Jonahss @bootstraponline |
| @@ -44,7 +44,7 @@ | |||
| private final String ipAddress; | |||
| private final long startupTimeout; | |||
| private final TimeUnit timeUnit; | |||
| private final ReentrantLock lock = new ReentrantLock(); | |||
| private final ReentrantLock lock = new ReentrantLock(true); | |||
There was a problem hiding this comment.
Maybe add a comment here mentioning true means fair ordering policy? It's not obvious what true does in the absence of a comment.
|
Code looks good to me. It's great you have tests! |
TikhomirovSergey
added a commit
that referenced
this pull request
Jan 14, 2016
#283 fix: Improvement of AppiumDriverLocalService for the multithreading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#283 fix Changes: