Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The refactoring and test coverage #316

Merged
merged 1 commit into from
Feb 8, 2016
Merged

The refactoring and test coverage #316

merged 1 commit into from
Feb 8, 2016

Conversation

TikhomirovSergey
Copy link
Contributor

Change list:

  • the command forming was moved from the AppiumDriver to MobileCommand
  • MobileCommand is a class now (was an interface).
  • Improved test coverage. Now there are tests for both Android and iOS (some test were for iOS only)

@TikhomirovSergey
Copy link
Contributor Author

@bootstraponline @imurchie
Please review these changes.

@TikhomirovSergey
Copy link
Contributor Author

#302

@bootstraponline
Copy link
Member

The merge commits should be rebased out of the commit history. Code looks good.

Change list:
- the command forming was moved from the AppiumDriver to MobileCommand
- MobileCommand is a class now (was an interface).
- Improved test coverage. Now there are tests for both Android and iOS (some test were for iOS only)
@TikhomirovSergey
Copy link
Contributor Author

Was improved. Now I'm merging.

TikhomirovSergey added a commit that referenced this pull request Feb 8, 2016
@TikhomirovSergey TikhomirovSergey merged commit 4ba7894 into appium:master Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants