Rotation support. #439
Rotation support. #439
Conversation
|
|
||
| @Override | ||
| public DeviceRotation rotation() { | ||
| Response response = execute(DriverCommand.GET_SCREEN_ROTATION); |
There was a problem hiding this comment.
ah sorry let me update this, forgot to commit this part.
|
Hi @Rafael-Chavez |
|
Ok, Firstly |
| <artifactId>selenium-java</artifactId> | ||
| <version>2.53.0</version> | ||
| <exclusions> |
There was a problem hiding this comment.
Why did you remove this?
|
It is interesting.
ping @SrinivasanTarget |
rafe-g
force-pushed
the
master
branch
3 times, most recently
from
e3a034f
to
c9db0ba
Compare
|
|
||
| @Override | ||
| public DeviceRotation rotation() { | ||
| Response response = execute(DriverCommand.GET_SCREEN_ROTATION); |
There was a problem hiding this comment.
The variable is being used.
|
It's really a cool feature 👍 I see we have this endpoint implemented only in |
|
@SrinivasanTarget actually the link you pasted is for the endpoint /rotate the mobile spec defines a /rotation endpoint. Maybe a good idea to merge these two? im not sure what spec this mobileRotation command was adhering to. Maybe @jlipps @imurchie can give more details? |
|
@TikhomirovSergey DeviceRotation class is proposed to be part of selenium project. |
rafe-g
force-pushed
the
master
branch
5 times, most recently
from
b39f2d0
to
c38451e
Compare
|
@TikhomirovSergey @SrinivasanTarget i updated the routes in the appium server to support this command. The selenium pull request has been merged already. |
|
@Rafael-Chavez Ok. It will be merged when it will be available in selenium. Are you agree? |
|
you mean on the next selenium release? |
|
Yes |
|
Closing this in favor of #489 |
Change list
Please provide briefly described change list which are you going to propose.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub