The addition to #477 #480
Merged
The addition to #477 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the enum `io.appium.java_client.android.ConfiguratorParameters` was removed - new elements were added to the `io.appium.java_client.android.Settings` - refactoring of the `io.appium.java_client.HasSettings`.
|
@SrinivasanTarget @truebit |
truebit
reviewed
Sep 29, 2016
| @@ -76,8 +76,7 @@ default void ignoreUnimportantViews(Boolean compress) { | |||
| * @param timeout in milliseconds, 0 would reset to its default value | |||
There was a problem hiding this comment.
negative value would reset, not 0, for all configurator settings.Because in some circumstances, 0 would be used to disable timeouts on purpose. see here
truebit
reviewed
Sep 29, 2016
| @@ -22,26 +22,23 @@ | |||
|
|
|||
| @Test public void configuratorTest() { | |||
| driver.configuratorSetActionAcknowledgmentTimeout(5); | |||
| assertJSONElementContains("setActionAcknowledgmentTimeout", 5); | |||
| assertJSONElementContains(Setting.WAIT_ACTION_ACKNOWLEDGMENT_TIMEOUT, 5); | |||
There was a problem hiding this comment.
timeout value is in milliseconds. use 500 or more could be more understandable.
|
@truebit ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
io.appium.java_client.android.ConfiguratorParameterswas removedio.appium.java_client.android.Settingsio.appium.java_client.HasSettings.Types of changes
What types of changes are you proposing/introducing to Java client?
Details
This change was made according to the conversation #477 (see the end)