TouchID Implementation [iOS Sim Only] #509

dpgraham · 2016-11-07T22:39:12Z

Change list

Added touchId command

Types of changes

What types of changes are you proposing/introducing to Java client?

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Touch ID is a feature in Apple products (see https://support.apple.com/en-ca/HT201371). This endpoint simulates the behaviour.

Tests were failing because of an indentation problem in IOSGesturesTest.java and because a static import in XCUIAutomationTest.java was coming after the rest of the imports instead of before

(See https://support.apple.com/en-ca/HT201371 for description of the Touch ID feature) This endpoint simulates the TouchID feature.

dpgraham · 2016-11-07T22:41:11Z

*Not sure why the README.md was diffed that way. I only added one line under the 'Added Functions' header

SrinivasanTarget · 2016-11-08T05:26:51Z

src/test/java/io/appium/java_client/ios/XCUIAutomationTest.java

@@ -31,8 +34,6 @@

 import java.io.File;

-import static org.junit.Assert.assertEquals;
-
 public class XCUIAutomationTest {


@dpgraham Can you add some tests here?

I added the test. It doesn't do any assertions because there isn't anything to check, it just calls the methods to verify that there aren't any exceptions.

SrinivasanTarget · 2016-11-08T05:27:52Z

src/main/java/io/appium/java_client/ios/IOSMobileCommandHelper.java

+    /**
+     * This method forms a {@link java.util.Map} of parameters for the touchId simulator
+     * 
+     * @param match Are we simulating a successful fingerprint scan?


Why is it a question here?

It's how I've documented boolean parameters in the past. I'll change it to be more in line with how it's normally documented.

SrinivasanTarget · 2016-11-08T05:29:19Z

src/main/java/io/appium/java_client/ios/IOSDeviceActionShortcuts.java

+     *
+     * @param match Are we simulating a successful fingerprint scan?
+     */
+    default void touchId(boolean match) {


Can you add in doc as it is Simulator only?

SrinivasanTarget · 2016-11-08T05:34:19Z

README.md

+- endTestCoverage()
+- isLocked()
+- shake()
+- touchId()


Can you revert this change? We will apply this change post release.

This will be added post release

This test only executes the driver.touchId method, it doesn't do any assertions. Just verifies that it doesn't throw any exceptions.

dpgraham · 2016-11-08T19:17:01Z

Thanks @SrinivasanTarget, I made the changes you requested. If you could review them and they're good let me know so that I can squash the changes and merge them.

TikhomirovSergey · 2016-11-10T12:40:13Z

src/test/java/io/appium/java_client/ios/XCUIAutomationTest.java

+            driver.touchId(false);
+            assertEquals(true, true);
+        } catch(Exception e){
+            assertEquals(true, false);


@dpgraham I think it is more senseful to throw an exception.
Otherwice we have a risk to produce and invalid build or to not react to server changes.

TikhomirovSergey · 2016-11-10T12:51:50Z

src/main/java/io/appium/java_client/ios/IOSDeviceActionShortcuts.java

@@ -56,5 +57,14 @@ default void hideKeyboard(String strategy, String keyName) {
    default void shake() {
        CommandExecutionHelper.execute(this, shakeCommand());
    }
+


@dpgraham

I am against the adding to the IOSDeviceActionShortcuts. This interface is going to be deprecated. Please take a look at this working branch. IOSDeviceActionShortcuts is going to be deprecated.

It is better to add such interface:

package io.appium.java_client.ios; public interface ChecksTouchId extends ExecutesMethod { /** * Simulate touchId event * * @param match If true, simulates a successful fingerprint scan. If false, simulates a failed fingerprint scan */ default void touchId(boolean match) { CommandExecutionHelper.execute(this, touchIdCommand(match)); } }

and make IOSDriver implement it.

Thanks for the input Sergey. I made the change.

TikhomirovSergey · 2016-11-10T12:54:04Z

@dpgraham
Sorry for the delaying. Usually busy. Please take a look at remarks.

SrinivasanTarget · 2016-11-10T17:40:59Z

src/test/java/io/appium/java_client/ios/XCUIAutomationTest.java

+        try {
+            driver.touchId(true);
+            driver.touchId(false);
+            assertEquals(true, true);


Actual Usecase of API touchID is to unlock or sign in to any application using touchID. Since we dont have our test app built with any registration or sign in feature, we cannot use that scenario.

Otherwise Can we lock the simulator and unlock the simulator using driver.touchID(true).Ideal case this should be working fine.

So test scenario should be something like,

try { driver.lockDevice(2); driver.touchId(true); } catch (Exception e) { assertTrue(false); }

SrinivasanTarget · 2016-11-10T17:42:07Z

src/main/java/io/appium/java_client/ios/IOSDeviceActionShortcuts.java

+    /**
+     * Simulate touchId event
+     *
+     * @param match If true, simulates a successful fingerprint scan. If false, simulates a failed fingerprint scan


If i'm not wrong, this will fail as per google style each doc line should end with a period.

SrinivasanTarget · 2016-11-10T17:46:23Z

@dpgraham I've reviewed again now. Please take a look.

Tests were failing because of an indentation problem in IOSGesturesTest.java and because a static import in XCUIAutomationTest.java was coming after the rest of the imports instead of before

(See https://support.apple.com/en-ca/HT201371 for description of the Touch ID feature) This endpoint simulates the TouchID feature.

This will be added post release

This test only executes the driver.touchId method, it doesn't do any assertions. Just verifies that it doesn't throw any exceptions.

-Moved touchID out of IOSDeviceActionShorcuts and into PerformsTouchID -Made IOSDriver implement PerformsTouchID -Fixed typo that I noticed in CommandExecutionHelper -Fixed linting errors

dpgraham · 2016-11-11T00:12:42Z

I've updated the code again

TikhomirovSergey · 2016-11-11T13:53:10Z

src/test/java/io/appium/java_client/ios/XCUIAutomationTest.java

+            driver.performTouchID(false);
+            assertEquals(true, true);
+        } catch (Exception e) {
+            assertEquals(true, false);


Test should throw the exception.

At least you can do that

try { //do something //assert the result } catch (Exception e) { throw e; } finally { //attemt to stabilize the simulator //or something else }

@dpgraham Can you update tests here as suggested please?

SrinivasanTarget · 2016-11-12T08:56:30Z

src/main/java/io/appium/java_client/ios/IOSMobileCommandHelper.java

+    /**
+     * This method forms a {@link java.util.Map} of parameters for the touchId simulator
+     * 
+     * @param match If true, simulates a successful fingerprint scan. If false, simulates a failed fingerprint scan


Doc should end with a period everywhere.

dpgraham · 2016-11-15T18:13:32Z

Changes made

TikhomirovSergey · 2016-11-17T18:05:03Z

@dpgraham Everuthing is ok for me. But could you please improve the proposed test the way I have asked?
@SrinivasanTarget ?

dpgraham added 2 commits November 7, 2016 13:03

Fixed broken tests

934d819

Tests were failing because of an indentation problem in IOSGesturesTest.java and because a static import in XCUIAutomationTest.java was coming after the rest of the imports instead of before

Added 'touch_id' endpoint

7ec088f

(See https://support.apple.com/en-ca/HT201371 for description of the Touch ID feature) This endpoint simulates the TouchID feature.

SrinivasanTarget requested changes Nov 8, 2016

View reviewed changes

SrinivasanTarget changed the title ~~Touch~~ TouchID Implementation [iOS Sim Only] Nov 8, 2016

SrinivasanTarget added enhancement iOS labels Nov 8, 2016

SrinivasanTarget added this to the 5.0.0 milestone Nov 8, 2016

drapostolos and others added 6 commits November 8, 2016 15:37

removed obselete gson-2.6.2 dependency. (#507)

9f214cd

Fix documentation

897330c

Fix documentation

39823da

Don't commit 'touchID()'

e5a500b

This will be added post release

Added touchId test

6880006

This test only executes the driver.touchId method, it doesn't do any assertions. Just verifies that it doesn't throw any exceptions.

Merge branch 'touch-id' of github.com:appium/java-client into touch-id

7ee13c9

Added assertion to keep codacy happy

1e395ff

TikhomirovSergey suggested changes Nov 10, 2016

View reviewed changes

SrinivasanTarget requested changes Nov 10, 2016

View reviewed changes

dpgraham added 9 commits November 10, 2016 11:13

Fixed broken tests

56dc2f0

Tests were failing because of an indentation problem in IOSGesturesTest.java and because a static import in XCUIAutomationTest.java was coming after the rest of the imports instead of before

Added 'touch_id' endpoint

fd9543c

(See https://support.apple.com/en-ca/HT201371 for description of the Touch ID feature) This endpoint simulates the TouchID feature.

Fix documentation

5b561e9

Fix documentation

8071a8b

Don't commit 'touchID()'

605eb3e

This will be added post release

Added touchId test

a9e580b

This test only executes the driver.touchId method, it doesn't do any assertions. Just verifies that it doesn't throw any exceptions.

Added assertion to keep codacy happy

d6a93c8

Moved touchID into new file

2f6f8ab

-Moved touchID out of IOSDeviceActionShorcuts and into PerformsTouchID -Made IOSDriver implement PerformsTouchID -Fixed typo that I noticed in CommandExecutionHelper -Fixed linting errors

Fixed conflicts

309862d

Fixed conflicts

fec5168

TikhomirovSergey suggested changes Nov 11, 2016

View reviewed changes

SrinivasanTarget requested changes Nov 12, 2016

View reviewed changes

Update IOSMobileCommandHelper.java

847dd63

Throws exception instead of bogus assertion

4233982

TikhomirovSergey approved these changes Nov 18, 2016

View reviewed changes

SrinivasanTarget approved these changes Nov 18, 2016

View reviewed changes

TikhomirovSergey merged commit 3e9c949 into master Nov 18, 2016

dpgraham deleted the touch-id branch November 18, 2016 14:41

SrinivasanTarget mentioned this pull request Dec 1, 2016

add finger print command to android Driver #473

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TouchID Implementation [iOS Sim Only] #509

TouchID Implementation [iOS Sim Only] #509

dpgraham commented Nov 7, 2016

dpgraham commented Nov 7, 2016

SrinivasanTarget Nov 8, 2016

dpgraham Nov 8, 2016

SrinivasanTarget Nov 8, 2016

dpgraham Nov 8, 2016

SrinivasanTarget Nov 8, 2016 •

edited

Loading

SrinivasanTarget Nov 8, 2016 •

edited

Loading

dpgraham commented Nov 8, 2016

TikhomirovSergey Nov 10, 2016

TikhomirovSergey Nov 10, 2016 •

edited

Loading

dpgraham Nov 11, 2016

TikhomirovSergey commented Nov 10, 2016

SrinivasanTarget Nov 10, 2016

SrinivasanTarget Nov 10, 2016

SrinivasanTarget Nov 10, 2016

SrinivasanTarget commented Nov 10, 2016

dpgraham commented Nov 11, 2016

TikhomirovSergey Nov 11, 2016

SrinivasanTarget Nov 17, 2016

SrinivasanTarget Nov 12, 2016

dpgraham commented Nov 15, 2016

TikhomirovSergey commented Nov 17, 2016 •

edited

Loading

TouchID Implementation [iOS Sim Only] #509

TouchID Implementation [iOS Sim Only] #509

Conversation

dpgraham commented Nov 7, 2016

Change list

Types of changes

Details

dpgraham commented Nov 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SrinivasanTarget Nov 8, 2016 • edited Loading

Choose a reason for hiding this comment

SrinivasanTarget Nov 8, 2016 • edited Loading

Choose a reason for hiding this comment

dpgraham commented Nov 8, 2016

Choose a reason for hiding this comment

TikhomirovSergey Nov 10, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TikhomirovSergey commented Nov 10, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SrinivasanTarget commented Nov 10, 2016

dpgraham commented Nov 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpgraham commented Nov 15, 2016

TikhomirovSergey commented Nov 17, 2016 • edited Loading

SrinivasanTarget Nov 8, 2016 •

edited

Loading

SrinivasanTarget Nov 8, 2016 •

edited

Loading

TikhomirovSergey Nov 10, 2016 •

edited

Loading

TikhomirovSergey commented Nov 17, 2016 •

edited

Loading