Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend FluentWait, so one can set custom polling strategy #612

Merged
merged 2 commits into from
Apr 2, 2017

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

Created extended FluentWait class with possibility to allow custom polling strategy. This might be quite useful while working with mobile interfaces where the initial transition animation creates main delay before an element appears on the screen. Having custom polling strategy set allows one to increase this initial polling delay, so the interface has enough time to finish the transition faster without being unnecessarily interrupted by Appium agent calls.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

I don't really like the implementation myself, since it is necessary to access private fields of the parent class via reflection API. Please let me know if you have better ideas on how to implement it.

@TikhomirovSergey TikhomirovSergey self-requested a review April 1, 2017 21:48
@TikhomirovSergey TikhomirovSergey merged commit b99cdfb into appium:master Apr 2, 2017
TikhomirovSergey added a commit that referenced this pull request Apr 2, 2017
@mykola-mokhnach mykola-mokhnach deleted the appium_fluent_wait branch April 3, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants