-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated youiengine #652
Deprecated youiengine #652
Conversation
@SrinivasanTarget @mykola-mokhnach Could you review it. FYI @pfoster-youitv @philgreenyouilabs @jlipps @simongranger |
@@ -23,6 +23,11 @@ | |||
|
|||
import java.net.URL; | |||
|
|||
@Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the common practice is to put a docsting before an annotation, but not after
@mykola-mokhnach @SrinivasanTarget I have updated it a little bit and now I am trying to notify youiengine guys. |
LGTM @TikhomirovSergey |
@TikhomirovSergey I think the best place to find them is general channel of Appium's slack. We could add your account if you are still not there. |
That was the main thing we needed and not be strictly tied to either iOS or Android elements/commands since we do not use Android or iOS native elements. 👍 |
@pfoster-youitv |
Change list
io.appium.java_client.youiengine
package was marked asDeprecated
com.google.code.gson:gson
to v2.8.1Types of changes
Details
This package was added at #429. It was accepted due to previous implementation was not flexible and it did not allowed user to use their own commands/JSONWP protocol extensions. Now
AppiumDriver
is not abstract and it can be used across supported platfoms.Please take a look at the following sample:
Also now it allows end user to extend command repository the following way:
Also I was motivated to remove this package because there is no activity/development.