added get_current_package session #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TikhomirovSergey @SrinivasanTarget pls review |
|
@saikrishna321 Hi. Thank you. I will review it ASAP. |
SrinivasanTarget
requested changes
Jun 16, 2017
| @@ -183,4 +183,8 @@ | |||
|
|
|||
| } | |||
|
|
|||
| @Test public void getCurrentPackage() { | |||
There was a problem hiding this comment.
Can we rename this to getCurrentPackageTest() ?
SrinivasanTarget
approved these changes
Jun 17, 2017
TikhomirovSergey
suggested changes
Jun 17, 2017
| @@ -180,4 +181,8 @@ public void openNotifications() { | |||
| public void toggleLocationServices() { | |||
| CommandExecutionHelper.execute(this, toggleLocationServicesCommand()); | |||
| } | |||
|
|
|||
| public String getCurrentPackage() { | |||
There was a problem hiding this comment.
I think it would be better to move this method to the io.appium.java_client.android.StartsActivity interface and to make it default.
TikhomirovSergey
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Appium 1.6.6 beta has a new endpoint for getting the currently running package during an Android test.
See appium/appium-base-driver@190a896
Re: appium/appium#8674
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply