Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toggleTouchIdEnrollment function #659

Merged
merged 3 commits into from
Jun 24, 2017
Merged

Add toggleTouchIdEnrollment function #659

merged 3 commits into from
Jun 24, 2017

Conversation

SrinivasanTarget
Copy link
Member

Change list

Fix #607

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

For ref appium/appium-xcuitest-driver#402

@dpgraham @TikhomirovSergey please review

@SrinivasanTarget SrinivasanTarget added this to the 5.0.0 milestone Jun 17, 2017
TikhomirovSergey
TikhomirovSergey reviewed Jun 23, 2017
View reviewed changes
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. @SrinivasanTarget Is test passed?

@SrinivasanTarget
Copy link
Member Author

@TikhomirovSergey Yes

@SrinivasanTarget SrinivasanTarget merged commit 92d09a4 into appium:master Jun 24, 2017
@SrinivasanTarget SrinivasanTarget deleted the touch_id branch June 24, 2017 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TikhomirovSergey TikhomirovSergey TikhomirovSergey approved these changes

@dpgraham dpgraham dpgraham approved these changes

Assignees
No one assigned
Labels
enhancement iOS
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Add toggleTouchIdEnrollment function
3 participants
@SrinivasanTarget @dpgraham @TikhomirovSergey