#696 FIX

[TikhomirovSergey]

Change list

• changes from the Address compilation error with selenium 3.5.1 #698
• selenium-java was updated to 3.5.x
• org.apache.commons-lang3 was updated to 3.6
• org.springframework.spring-context was updated to 4.3.10.RELEASE
• the element genering was improved. Warning: Selenium 3.5.1 breaks java client 5.0.0-BETA9 #696 FIX
• some improvements of AppiumDriver#context

Types of changes

• No changes in production code.
• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

I suppose that it is the last change and we should publish 5.0.0. All the pended pull-requests will be merged and published at 5.1.0

[mykola-mokhnach]

it would be nice to know whether it is possible to limit the update of major component version, so it would be possible to avoid similar compilation issues in the future. I'm thinking about the same logic, like in package.json for Node JS modules, where one can say "bla: ^1.0" and this will block the component "bla" from major version update (however, minor version updates are allowed)

[TikhomirovSergey]

@mykola-mokhnach Ok I will google how the similar problems are resolved.

[mykola-mokhnach]

Seems like this might be a good match to our purposes: https://stackoverflow.com/questions/39664589/use-semantic-versioning-for-a-dependency-in-gradle

[SrinivasanTarget]

@TikhomirovSergey @mykola-mokhnach i think it only restricts selenium-java dependency and not its sub modules or transitive dependency.

[SrinivasanTarget]

@TikhomirovSergey We are good to update to 3.5.2 as 3.5.+. I don't see any issues on yesterday's selenium release.

[mykola-mokhnach]

I've almost created the same. Although having Selenium version assigned to a single variable looks more elegant to me ;)

[mykola-mokhnach]

or even shorter:

ext.seleniumVersion = '3.4.+'

dependencies {
    compile ("org.seleniumhq.selenium:selenium-java:${seleniumVersion}") {
        force = true

        exclude module: 'cglib'
        exclude group: 'com.google.code.gson'
    }
    compile ("org.seleniumhq.selenium:selenium-support:${seleniumVersion}") {
        force = true
    }
    compile ("org.seleniumhq.selenium:selenium-api:${seleniumVersion}") {
        force = true
    }

[SrinivasanTarget]

Awesome Looks good 👍

[TikhomirovSergey]

@mykola-mokhnach @SrinivasanTarget Hi guys. Thank you for the discussion and advices. Today I am going to update the PR

[SrinivasanTarget]

Sure @TikhomirovSergey

[mykola-mokhnach]

[ant:checkstyle] [ERROR] /home/travis/build/appium/java-client/src/main/java/io/appium/java_client/AppiumDriver.java:215:9: '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). [RightCurly]
:checkstyleMain FAILED

[TikhomirovSergey]

@mykola-mokhnach
Yes I know about the check style issue and I will get it fixed ASAP

[TikhomirovSergey]

@mykola-mokhnach @SrinivasanTarget I have updated this PR

[mykola-mokhnach]

Yep, now the PR looks much better. @TikhomirovSergey please merge it