Add isKeyboardShown command for iOS #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import static io.appium.java_client.MobileCommand.isKeyboardShownCommand; | ||
|
|
||
| public interface HasDeviceDetails extends ExecutesMethod { |
There was a problem hiding this comment.
I'd rather rename the interface to HasOnScreenKeyboard
| @@ -64,7 +64,7 @@ | |||
| */ | |||
| @SuppressWarnings("unchecked") | |||
| public class AppiumDriver<T extends WebElement> | |||
| extends DefaultGenericMobileDriver<T> implements ComparesImages { | |||
| extends DefaultGenericMobileDriver<T> implements ComparesImages, HasDeviceDetails { | |||
There was a problem hiding this comment.
I'd rather add it to only ios and Android drivers, but not to the generic one.
| @@ -51,7 +51,7 @@ | |||
| public class AndroidDriver<T extends WebElement> | |||
| extends AppiumDriver<T> | |||
| implements PressesKeyCode, HasNetworkConnection, PushesFiles, StartsActivity, | |||
| FindsByAndroidUIAutomator<T>, LocksDevice, HasAndroidSettings, HasDeviceDetails, | |||
| FindsByAndroidUIAutomator<T>, LocksDevice, HasAndroidSettings, HasAndroidDeviceDetails, | |||
| HasSupportedPerformanceDataType, AuthenticatesByFinger, | |||
| CanRecordScreen, SupportsSpecialEmulatorCommands, | |||
| SupportsNetworkStateManagement, ListensToLogcatMessages, HasAndroidClipboard { | |||
There was a problem hiding this comment.
The interface should be added to AndroidDriver as well
| import static io.appium.java_client.android.AndroidMobileCommandHelper.getDisplayDensityCommand; | ||
| import static io.appium.java_client.android.AndroidMobileCommandHelper.getSystemBarsCommand; | ||
|
|
||
| public interface HasAndroidDeviceDetails extends HasOnScreenKeyboard { |
There was a problem hiding this comment.
I'd rather add the extension separately.
mykola-mokhnach
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Add isKeyboardShown command for iOS
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply