Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand touch options API to accept coordinates as Point #997

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

valfirst
Copy link
Collaborator

Change list

Expand touch options API to accept coordinates as org.openqa.selenium.Point

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@@ -71,7 +72,7 @@ public void longPressOptionsShouldBuildProperly() {
@Test
public void tapOptionsShouldBuildProperly() {
final Map<String, Object> actualOpts = tapOptions()
.withPosition(point(0, 0))
.withPosition(point(new Point(0, 0)))
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so now both would be possible: point(0, 0) and point(new Point(0, 0)) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes both are possible now.

@saikrishna321 saikrishna321 merged commit 97ce87f into appium:master Aug 24, 2018
@valfirst valfirst deleted the use-coordinates-as-point branch July 7, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants