Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Allow authGSSClientInit principal kwarg to be None. #52

Merged
merged 1 commit into from
Oct 13, 2016

Conversation

kwlzn
Copy link
Contributor

@kwlzn kwlzn commented Sep 30, 2016

This PR simply applies the patch from #49 for easier merging.

Fixes #49

@dreness
Copy link
Member

dreness commented Sep 30, 2016

Hi @kwlzn

We don't yet have any automated tests hooked up for this project. Some of the included tests require admin-level access to a kerberized service of some variety. If you happen to have such a configuration at your disposal, would you mind running through the included tests (with your patch applied) and posting your results?

I just added some testing notes to clarify how the tests are used, and the requirements / preconditions for each. Normally I wouldn't ask you to do this, but since I don't have an environment handy for this, and since you asked for expediting, this might be a chance to speed things along a bit. If not, that's fine too, I will just need to set up a test environment (which shouldn't take all that long...).

@kwlzn
Copy link
Contributor Author

kwlzn commented Oct 1, 2016

@dreness I unfortunately do not have admin-level access within our infra, sorry. :(

@dreness
Copy link
Member

dreness commented Oct 4, 2016

Just spent a lot of hours trying to get the tests to run against a system which I am now declaring to be too complicated for this purpose (apple's Server.app web service). I will try to find the simplest docker thing that I can find instead; unfortunately I don't remember exactly what I used last time.

@cyrusdaboo
Copy link
Contributor

This change looks OK to me.

Copy link
Contributor

@cyrusdaboo cyrusdaboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants