Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Page Accounting Fixes to CUPS 2.2.x #5439

Closed
zdohnal opened this issue Nov 16, 2018 · 4 comments
Closed

Backport Page Accounting Fixes to CUPS 2.2.x #5439

zdohnal opened this issue Nov 16, 2018 · 4 comments
Assignees

Comments

@zdohnal
Copy link
Contributor

zdohnal commented Nov 16, 2018

Hi Mike,

I was going to rebase CUPS in Fedora to 2.2.9, so I ran 'make check' above the source (without any downstream patches applied) and I found out one test is failing:

PASS: cupsd exited with no errors.
PASS: All job control files purged.
PASS: Printer 'Test1' correctly produced 113 page(s).
PASS: Printer 'Test2' correctly produced 23 page(s).
FAIL: Printer 'Test3' produced 5 page(s), expected 4.
PASS: 163 requests logged.

Test3 is ipp everywhere printer, created in test by:
lpadmin -p Test3 -E -v ipp://localhost:8631/printers/Test2 -m everywhere

Here are the logs:
cups-str-2018-11-16-zdohnal.html.txt

The test passed with cups-2.2.8. Would you mind looking into it?

@zdohnal
Copy link
Contributor Author

zdohnal commented Nov 16, 2018

It seems the printer uses rastertohp filter from logs.

@michaelrsweet
Copy link
Collaborator

I've done a bunch of runs of 'make check' - some pass, some fail. I believe the issue is that the page accounting isn't 100% reliable. I will investigate back-porting the CUPS 2.3 accounting changes.

In the meantime, this particular failure shouldn't prevent you from using 2.2.9...

@michaelrsweet michaelrsweet self-assigned this Nov 16, 2018
@michaelrsweet michaelrsweet added this to the CUPS 2.2.x Updates milestone Nov 16, 2018
@michaelrsweet michaelrsweet changed the title cups-2.2.9 test fail - printing to printer with deskjet.ppd produces more pages than expected Backport Page Accounting Fixes to CUPS 2.2.x Nov 16, 2018
@michaelrsweet
Copy link
Collaborator

Original changes in Issue #4991.

@michaelrsweet
Copy link
Collaborator

[branch-2.2 450310b] Back-port accounting changes from CUPS 2.3 (Issue #5439)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants