Correct problem with memory access violation for incorrect PPD file #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParamCustom* keywords with the same name and different type. In this case the PPD parser may cause memory leak or memory violation when one of the type is PPD_CUSTOM_PASSCODE, PPD_CUSTOM_PASSWORD or PPD_CUSTOM_STRING.
|
@ppawliczek Please attach the problematic PPD file. |
|
The PPS file is incorrect, however it should not cause incorrect memory reads. clusterfuzz-testcase-minimized-cups_ppdopen_fuzzer-6243187697647616.zip |
michaelrsweet
added a commit
that referenced
this pull request
Aug 1, 2019
michaelrsweet
added a commit
that referenced
this pull request
Aug 1, 2019
michaelrsweet
added a commit
that referenced
this pull request
Aug 1, 2019
michaelrsweet
added
priority-high
and removed
investigating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem occurres when an input PPD file contains a pair of the same
ParamCustom* keywords with the same name and different type. In this case
the PPD parser may cause memory leak or memory violation when one of
the type is PPD_CUSTOM_PASSCODE, PPD_CUSTOM_PASSWORD or PPD_CUSTOM_STRING.
A parameter with expected parameter type is added to ppd_get_cparam(...).