Skip to content

Commit

Permalink
Mark coordinator endpoints as not failed on the client if we can't de…
Browse files Browse the repository at this point in the history
…termine the protocol version in order to trigger leader monitoring communication.
  • Loading branch information
sfc-gh-abeamon committed Apr 30, 2021
1 parent e32803f commit 54d6176
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion fdbclient/NativeAPI.actor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4175,7 +4175,11 @@ ACTOR Future<ProtocolVersion> getCoordinatorProtocolFromConnectPacket(NetworkAdd
FlowTransport::transport().getPeerProtocolAsyncVar(coordinatorAddress);

loop {
if (protocolVersion->get().present() && protocolVersion->get() != expectedVersion) {

if (!protocolVersion->get().present()) {
// Mark the endpoint as not failed to trigger communication via leader monitoring
IFailureMonitor::failureMonitor().setStatus(coordinatorAddress, FailureStatus(false));
} else if (protocolVersion->get() != expectedVersion) {
return protocolVersion->get().get();
}

Expand Down

0 comments on commit 54d6176

Please sign in to comment.