-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger buildTeam operation if server transition from unhealthy -> healthy #5930
Merged
sfc-gh-ahusain
merged 3 commits into
apple:master
from
sfc-gh-ahusain:ahusain-fixBuildTeam
Nov 12, 2021
Merged
Trigger buildTeam operation if server transition from unhealthy -> healthy #5930
sfc-gh-ahusain
merged 3 commits into
apple:master
from
sfc-gh-ahusain:ahusain-fixBuildTeam
Nov 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…althy DataDistribution actor helps in building teams as server count changes (add/removal), however, it is possible that total_healthy_server count is insufficient to allow team formation. If happens, even healthy server count recover, the buildTeam operation will not be triggered. Patch proposal is to trigger `checkBuildTeam` operation if server transitions from unhealthy -> healthy state. Incase system already has created enough teams (desiredTeamCount/maxTeamCount), the operation incurs a very minimal cost.
AWS CodeBuild CI Report for macOS Catalina 10.15
|
…althy DataDistribution actor helps in building teams as server count changes (add/removal), however, it is possible that total_healthy_server count is insufficient to allow team formation. If happens, even healthy server count recover, the buildTeam operation will not be triggered. Patch proposal is to trigger `checkBuildTeam` operation if server transitions from unhealthy -> healthy state. Incase system already has created enough teams (desiredTeamCount/maxTeamCount), the operation incurs a very minimal cost.
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for macOS Catalina 10.15
|
sfc-gh-etschannen
previously approved these changes
Nov 9, 2021
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
…althy DataDistribution actor helps in building teams as server count changes (add/removal), however, it is possible that total_healthy_server count is insufficient to allow team formation. If happens, even healthy server count recover, the buildTeam operation will not be triggered. Patch proposal is to trigger `checkBuildTeam` operation if server transitions from unhealthy -> healthy state. Incase system already has created enough teams (desiredTeamCount/maxTeamCount), the operation incurs a very minimal cost.
AWS CodeBuild CI Report for macOS Catalina 10.15
|
AWS CodeBuild CI Report for Linux CentOS 7
|
sfc-gh-xwang
approved these changes
Nov 11, 2021
sfc-gh-ahusain
added a commit
to sfc-gh-ahusain/foundationdb
that referenced
this pull request
Nov 16, 2021
…althy (apple#5930) * Trigger buildTeam operation if server transition from unhealthy -> healthy DataDistribution actor helps in building teams as server count changes (add/removal), however, it is possible that total_healthy_server count is insufficient to allow team formation. If happens, even healthy server count recover, the buildTeam operation will not be triggered. Patch proposal is to trigger `checkBuildTeam` operation if server transitions from unhealthy -> healthy state. Incase system already has created enough teams (desiredTeamCount/maxTeamCount), the operation incurs a very minimal cost.
sfc-gh-ahusain
added a commit
to sfc-gh-ahusain/foundationdb
that referenced
this pull request
Nov 16, 2021
…althy (apple#5930) * Trigger buildTeam operation if server transition from unhealthy -> healthy DataDistribution actor helps in building teams as server count changes (add/removal), however, it is possible that total_healthy_server count is insufficient to allow team formation. If happens, even healthy server count recover, the buildTeam operation will not be triggered. Patch proposal is to trigger `checkBuildTeam` operation if server transitions from unhealthy -> healthy state. Incase system already has created enough teams (desiredTeamCount/maxTeamCount), the operation incurs a very minimal cost.
jzhou77
pushed a commit
that referenced
this pull request
Nov 17, 2021
…althy (#5930) * Trigger buildTeam operation if server transition from unhealthy -> healthy DataDistribution actor helps in building teams as server count changes (add/removal), however, it is possible that total_healthy_server count is insufficient to allow team formation. If happens, even healthy server count recover, the buildTeam operation will not be triggered. Patch proposal is to trigger `checkBuildTeam` operation if server transitions from unhealthy -> healthy state. Incase system already has created enough teams (desiredTeamCount/maxTeamCount), the operation incurs a very minimal cost.
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataDistribution actor helps in building teams as server count changes
(add/removal), however, it is possible that total_healthy_server count
is insufficient to allow team formation. If happens, even healthy server
count recover, the buildTeam operation will not be triggered.
Patch proposal is to trigger
checkBuildTeam
operation if servertransitions from unhealthy -> healthy state. Incase system already
has created enough teams (desiredTeamCount/maxTeamCount), the operation
incurs a very minimal cost.
Put description here...
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormaster
if this is the youngest branch)