Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hyphens to front of character class #308

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

Cldfire
Copy link
Collaborator

@Cldfire Cldfire commented Aug 13, 2020

According to the spec, hyphens are only valid at the very beginning of a character class:

The dash character (-) is reserved as a special character. To list '-' as a literal character it must appear immediately after the opening square bracket '['.

Our parser over at @1Password caught a couple rules in the list that have the - in non-valid places, so I moved them to the start of the character class in this PR.

Overall Checklist

Copy link
Collaborator

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rmondello rmondello merged commit 61cbf69 into apple:main Aug 18, 2020
@rmondello
Copy link
Contributor

Thanks @Cldfire! I’m still working on getting us some automation that’ll check this. (I know it’s been a while. The problems are non-technical.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants