Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Telegram domains to Shared Credentials #802

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

gracjankn
Copy link
Contributor

@gracjankn gracjankn commented Aug 24, 2024

Overall Checklist

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)
  • If using from and to, the new group, the from domain(s) redirect to the to domain to log in.

Telegram.me is used to autofill credentials in Telegram for iOS. Telegram.org is used for the web app (https://web.telegram.org).

"ting.com",
"telegram.org",
"telegram.me"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, telegram.me redirects to telegram.org, so a “from” / “to” relationship would be more correct here.

Copy link
Contributor Author

@gracjankn gracjankn Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does redirect when opened in the browser, however Password Autofill on iOS suggests an account for login to the Telegram app only if "telegram.me" is also added to the domains in the Passwords app.

Would "from" and "to" relationship work in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On iOS, we will interpret this correctly and do exactly what you want. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the relationship type in the new commit. Does that look right?

@rmondello rmondello merged commit fcf3cc0 into apple:main Aug 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants