Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interspersed proposal #259

Merged
merged 2 commits into from
May 10, 2023
Merged

Conversation

FranzBusch
Copy link
Member

Motivation

Add a new evolution proposal for the interspersed algorithm.

# Motivation

Our old proposals had a couple of stale links and were not all aligned. This cleans them up.
@FranzBusch
Copy link
Member Author

This depends on #258 to be merged

Copy link
Member

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me modulo the slight consistency naming nit.

@@ -44,7 +55,7 @@ extension AsyncInterspersedSequence: AsyncSequence {
public typealias Element = Base.Element

/// The iterator for an `AsyncInterspersedSequence` asynchronous sequence.
public struct Iterator: AsyncIteratorProtocol {
public struct AsyncIterator: AsyncIteratorProtocol {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency; other AsyncSequence types name this Iterator.

@FranzBusch FranzBusch force-pushed the fb-interspersed-proposal branch from 8e22bb7 to 99913fc Compare May 10, 2023 12:17
# Motivation
Add a new evolution proposal for the interspersed algorithm.
@FranzBusch FranzBusch force-pushed the fb-interspersed-proposal branch from 99913fc to 234fd9f Compare May 10, 2023 12:19
@FranzBusch
Copy link
Member Author

@swift-ci test

@FranzBusch FranzBusch merged commit b339466 into apple:main May 10, 2023
@FranzBusch FranzBusch deleted the fb-interspersed-proposal branch May 10, 2023 14:18
@FranzBusch
Copy link
Member Author

Merging over known CI failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants