Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rethrows position #187

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Fix rethrows position #187

merged 1 commit into from
Oct 9, 2022

Conversation

ensan-hcl
Copy link
Contributor

Minor typo fix: Move rethrows before allow.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@ensan-hcl ensan-hcl requested a review from lorentey as a code owner September 29, 2022 06:29
@lorentey lorentey changed the base branch from main to release/1.0 September 30, 2022 00:59
@lorentey lorentey changed the base branch from release/1.0 to main September 30, 2022 01:00
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@lorentey
Copy link
Member

@ensan-hcl It would make sense to include this in the next bug fix release (1.0.4). Would you mind rebasing your branch on release/1.0 instead of main? (I'll then make sure the commit gets forwarded to release/1.1 and main in followup work.)

(It's also no big deal if you can't easily do that -- just let me know & I'll simply land it on main & cherry pick it to release/1.0 instead.)

@lorentey lorentey added this to the 1.0.4 milestone Sep 30, 2022
Minor typo fix.
@ensan-hcl
Copy link
Contributor Author

I updated the branch!

@lorentey lorentey changed the base branch from main to release/1.0 October 9, 2022 20:11
@lorentey
Copy link
Member

lorentey commented Oct 9, 2022

@swift-ci test

@lorentey lorentey merged commit 8bf9206 into apple:release/1.0 Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants