Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Backport Sendable conformances on all public types #343

Merged
merged 2 commits into from
Dec 18, 2023
Merged

[1.0] Backport Sendable conformances on all public types #343

merged 2 commits into from
Dec 18, 2023

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Dec 18, 2023 •
edited
Loading

This backports #191 to the release/1.0 branch, retrofitting that release series with proper support for Swift 5.5.

Resolves #317

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@lorentey lorentey added OrderedCollections OrderedSet and OrderedDictionary Deque The double-ended queue type labels Dec 18, 2023
@lorentey lorentey added this to the 1.0.6 milestone Dec 18, 2023
@lorentey lorentey requested review from glessard and Azoy December 18, 2023 23:27
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

macOS PR tests are expected to fail. 🐶🔥

@lorentey lorentey linked an issue Dec 18, 2023 that may be closed by this pull request
Ship Sendable annotations in 1.0.6 #317
Closed
@lorentey
Copy link
Member Author

@swift-ci test linux platform

@lorentey lorentey merged commit 03d60be into apple:release/1.0 Dec 18, 2023
1 check passed
@lorentey lorentey deleted the sendable-1.0 branch December 18, 2023 23:43
This was referenced Dec 18, 2023
Closed
Merged
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Dec 21, 2023
@cgrindel-self-hosted-renovate
chore(deps): update dependency com_github_apple_swift_collections to …
c56a21c 
…v1.0.6 (#822)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[com_github_apple_swift_collections](https://github.com/apple/swift-collections)
| http_archive | patch | `1.0.5` -> `1.0.6` |

---

### Release Notes

<details>
<summary>apple/swift-collections
(com_github_apple_swift_collections)</summary>

###
[`v1.0.6`](https://github.com/apple/swift-collections/releases/tag/1.0.6):
Swift Collections 1.0.6

[Compare
Source](https://github.com/apple/swift-collections/compare/1.0.5...1.0.6)

This bugfix release adds `Sendable` conformances to all public types
(fixing compatibility with Swift's strict concurrency checking), and
speeds up equality checks (`==`) of identical collection values.

##### What's Changed

- Fix typos: OrderedSet Documentation by
[@&#8203;kati-kms](https://github.com/kati-kms) in
[https://github.com/apple/swift-collections/pull/322](https://github.com/apple/swift-collections/pull/322)
- \[1.0] build: support building in Debug mode on Windows by
[@&#8203;compnerd](https://github.com/compnerd) in
[https://github.com/apple/swift-collections/pull/337](https://github.com/apple/swift-collections/pull/337)
- build: tweak search path for embedding by
[@&#8203;compnerd](https://github.com/compnerd) in
[https://github.com/apple/swift-collections/pull/338](https://github.com/apple/swift-collections/pull/338)
- \[OrderedDictionary] forward ordered dictionary values equality to
values property by [@&#8203;vanvoorden](https://github.com/vanvoorden)
in
[https://github.com/apple/swift-collections/pull/335](https://github.com/apple/swift-collections/pull/335)
- \[OrderedSet] forward ordered set equality to elements property by
[@&#8203;vanvoorden](https://github.com/vanvoorden) in
[https://github.com/apple/swift-collections/pull/340](https://github.com/apple/swift-collections/pull/340)
- \[Deque] check deque equality with buffer identity by
[@&#8203;vanvoorden](https://github.com/vanvoorden) in
[https://github.com/apple/swift-collections/pull/341](https://github.com/apple/swift-collections/pull/341)
- \[OrderedDictionary] Fix usage of deprecated API in index(forKey:)
docs by [@&#8203;lorentey](https://github.com/lorentey) in
[https://github.com/apple/swift-collections/pull/342](https://github.com/apple/swift-collections/pull/342)
- \[1.0] Backport Sendable conformances on all public types by
[@&#8203;lorentey](https://github.com/lorentey) in
[https://github.com/apple/swift-collections/pull/343](https://github.com/apple/swift-collections/pull/343)
- OrderedSet: Fix sendable conformance on old swifts by
[@&#8203;lorentey](https://github.com/lorentey) in
[https://github.com/apple/swift-collections/pull/346](https://github.com/apple/swift-collections/pull/346)
- Update CMake configuration by
[@&#8203;lorentey](https://github.com/lorentey) in
[https://github.com/apple/swift-collections/pull/347](https://github.com/apple/swift-collections/pull/347)

##### New Contributors

- [@&#8203;kati-kms](https://github.com/kati-kms) made their first
contribution in
[https://github.com/apple/swift-collections/pull/322](https://github.com/apple/swift-collections/pull/322)
- [@&#8203;vanvoorden](https://github.com/vanvoorden) made their first
contribution in
[https://github.com/apple/swift-collections/pull/335](https://github.com/apple/swift-collections/pull/335)

**Full Changelog**:
apple/swift-collections@1.0.5...1.0.6

Thank you to everyone who contributed to this release!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glessard glessard glessard approved these changes

@Azoy Azoy Awaiting requested review from Azoy

Assignees
No one assigned
Labels
Deque The double-ended queue type OrderedCollections OrderedSet and OrderedDictionary
Projects
None yet
Milestone
1.0.6
Development

Successfully merging this pull request may close these issues.

Ship Sendable annotations in 1.0.6
2 participants
@lorentey @glessard