[CMake] Reduce path lengths in single-module build #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the single module build would add each modules sources to a different list, and then we would combine the list prepending each element with a path like
../BitArray
or../RopeModule
. This resulted in extremely long build paths when built as a CMake FetchContent dependency which exceeded the maximum path length on Windows. To resolve this issue, we now create the single module target at theSources
level, and then calltarget_sources
in each subdirectory with a normal relative path such asBitArray+Description.swift
. This results in significantly smaller build directory structures keeping the path length within the Windows maximum and also cleans up the CMake a bit.Checklist