Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xcode template file with license comment. #40

Merged
merged 1 commit into from
May 21, 2021

Conversation

vihanb
Copy link
Contributor

@vihanb vihanb commented May 21, 2021

This adds an IDETemplateMacros.plist which means all files created through Xcode automatically have the correct header comment generated with them.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@vihanb vihanb requested a review from lorentey as a code owner May 21, 2021 03:09
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@lorentey
Copy link
Member

@swift-ci test

@lorentey lorentey merged commit fcb788c into apple:main May 21, 2021
<plist version="1.0">
<dict>
<key>FILEHEADER</key>
<string>===----------------------------------------------------------------------===//

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string>===----------------------------------------------------------------------===//
<string>//===----------------------------------------------------------------------===//

I think this line is missing a "//"

Copy link

@kylemacomber kylemacomber May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the same thing, but it looks like Xcode hardcodes inserting the leading //

Copy link

@WowbaggersLiquidLunch WowbaggersLiquidLunch May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, Xcode does insert the leading "//". I should've checked it first before commenting.

Weirdly though, this template doesn't for me locally, and it only seems to work in an Xcode project.

@lorentey lorentey added this to the 0.0.3 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants