Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes link to combinatorics. #8

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

powerje
Copy link
Contributor

@powerje powerje commented Apr 6, 2021

The link to Combinatorics appears to be wrong, this change updates it to Combinatorics.swift.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've updated the documentation if necessary.

@powerje powerje requested a review from lorentey as a code owner April 6, 2021 14:02
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for catching this! 👍

@lorentey
Copy link
Member

lorentey commented Apr 6, 2021

@swift-ci test

@lorentey
Copy link
Member

lorentey commented Apr 6, 2021

Oh hey, the build got hit by issue #7!

13:53:31 
<unknown>:0: error: fatal error encountered while reading from module 'OrderedCollections'; please file a bug report with your project and the crash log
13:53:31 <unknown>:0: note: module 'OrderedCollections' full misc version is '5.3.2(5.3.2)/Apple Swift version 5.3.2 (swiftlang-1200.0.45 clang-1200.0.32.28)'
13:53:31 
13:53:31 *** DESERIALIZATION FAILURE (please include this section in any bug report) ***
13:53:31 result not found
13:53:31 Cross-reference to module 'OrderedCollections'
13:53:31 ... OrderedSet
13:53:31 ... in an extension in module 'OrderedCollections'
13:53:31 ... Element
13:53:31 
13:53:31 Stack dump:
[...]
13:53:31 1.	Apple Swift version 5.3.2 (swiftlang-1200.0.45 clang-1200.0.32.28)
13:53:31 2.	While deserializing SIL function "$s18OrderedCollections0A3SetV12intersectionyACyxGAEF"
13:53:31 3.	While reading from 'OrderedCollections'
13:53:31 4.	While finishing conformance for protocol conformance to 'Collection' (in module 'Swift') for type 'OrderedSet<Element>'

@lorentey
Copy link
Member

lorentey commented Apr 9, 2021

@swift-ci test

@lorentey lorentey merged commit acdb003 into apple:main Apr 9, 2021
@lorentey lorentey added this to the 0.0.2 milestone Apr 10, 2021
@powerje powerje deleted the fix_link_to_combinatorics branch June 10, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants