Use Set to spot duplicated log handler warnings. #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Feels like a better fit for the problem when a dictionary of bools. Modifications: Convert storage to set. Result: Fewer lines of code, less waste.
FranzBusch
approved these changes
Jun 10, 2024
Lukasa
approved these changes
Jun 10, 2024
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Jun 27, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [apple/swift-log](https://github.com/apple/swift-log) | minor | `from: "1.5.4"` -> `from: "1.6.1"` | --- ### Release Notes <details> <summary>apple/swift-log (apple/swift-log)</summary> ### [`v1.6.1`](https://github.com/apple/swift-log/releases/tag/1.6.1): Swift Log 1.6.1 [Compare Source](https://github.com/apple/swift-log/compare/1.6.0...1.6.1) ##### SemVer Patch - Disable existential any build setting ([#​312](https://github.com/apple/swift-log/issues/312)) ### [`v1.6.0`](https://github.com/apple/swift-log/releases/tag/1.6.0) [Compare Source](https://github.com/apple/swift-log/compare/1.5.4...1.6.0) #### SemVer Minor - Add Sendability annotations in [https://github.com/apple/swift-log/pull/308](https://github.com/apple/swift-log/pull/308) - Fix deprecation warnings around default log implementations on handlers in [https://github.com/apple/swift-log/pull/310](https://github.com/apple/swift-log/pull/310) - Drop Swift versions earlier than 5.8 in [https://github.com/apple/swift-log/pull/299](https://github.com/apple/swift-log/pull/299) - Implement Copy-On-Write (CoW) behavior for Logger struct by [@​ayushi2103](https://github.com/ayushi2103) in [https://github.com/apple/swift-log/pull/297](https://github.com/apple/swift-log/pull/297) ##### SemVer Patch - Replace standardOutput to standardError by [@​ayushi2103](https://github.com/ayushi2103) in [https://github.com/apple/swift-log/pull/295](https://github.com/apple/swift-log/pull/295) - Use Set to spot duplicated log handler warnings in [https://github.com/apple/swift-log/pull/306](https://github.com/apple/swift-log/pull/306) - Make protocol usage obvious using any and some keywords in [https://github.com/apple/swift-log/pull/307](https://github.com/apple/swift-log/pull/307) - Remove documentation for non-existent arguments by [@​b1ackturtle](https://github.com/b1ackturtle) in [https://github.com/apple/swift-log/pull/309](https://github.com/apple/swift-log/pull/309) - Remove Docc plugin which is no longer required in [https://github.com/apple/swift-log/pull/311](https://github.com/apple/swift-log/pull/311) ##### Other Changes - Remove archived repository in [https://github.com/apple/swift-log/pull/292](https://github.com/apple/swift-log/pull/292) - Add CI for Swift 5.10 in [https://github.com/apple/swift-log/pull/287](https://github.com/apple/swift-log/pull/287) - Added swift-log-ecs to README.md by [@​rwbutler](https://github.com/rwbutler) in [https://github.com/apple/swift-log/pull/298](https://github.com/apple/swift-log/pull/298) - Update README.md add shipbook as backend by [@​elishas](https://github.com/elishas) in [https://github.com/apple/swift-log/pull/304](https://github.com/apple/swift-log/pull/304) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Feels like a better fit for the problem when a dictionary of bools.
Modifications:
Convert storage to set.
Result:
Fewer lines of code, less waste.