Implement RFC8441 Extended CONNECT #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-server-bot add to allowlist |
Lukasa
reviewed
Jun 20, 2024
Sources/NIOHTTP2/ConnectionStateMachine/HasExtendedConnectSettings.swift
Outdated
Show resolved
Hide resolved
…ings.swift Co-authored-by: Cory Benfield <lukasa@apple.com>
glbrntt
requested changes
Jun 21, 2024
| @@ -106,6 +106,7 @@ extension HeaderBlockValidator { | |||
| /// An object that can be used to validate if a given header block is a valid request header block. | |||
| fileprivate struct RequestBlockValidator { | |||
| private var isConnectRequest: Bool = false | |||
| private var containsProtocolPseudoheader: Bool = false | |||
There was a problem hiding this comment.
nit: casing should be PseudoHeader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #92