Reduce allocs in HTTP2StreamChannel #449
Conversation
|
It would be useful to get an idea of whether there's any significant performance impact to this change. I suspect that for most applications it comes out about neutral, but I'm not sure. |
This will obviously depend on how frequently A concrete example is AHC which uses it a few times per request (in channel active and when writability changes). I used it to benchmark against httpbin (running locally) and the difference was negligible. |
|
You'll need to update the allocations for main too |
Motivation: The HTTP2StreamChannel stores two atomic booleans for whether the channel is active and writable. These are only accessed externally and access is relatively infrequent. Each atomic requires an allocation, instead we can just protect each with a single lock. Modifications: - Combine the two atomics into a single 'flags' struct protected by a locked value box Result: Fewer alloations
Motivation:
The HTTP2StreamChannel stores two atomic booleans for whether the channel is active and writable. These are only accessed externally and access is relatively infrequent. Each atomic requires an allocation, instead we can just protect each with a single lock.
Modifications:
Result:
Fewer alloations