Enable MemberImportVisibility check on all targets #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
07db031 to
2a777b8
Compare
rnro
changed the title
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
2a777b8 to
4bf8a60
Compare
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
4bf8a60 to
ab3a37a
Compare
rnro
added
🔨 semver/patch
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
3 times, most recently
from
af7113c to
56cbb35
Compare
rnro
force-pushed
the
enable_MemberImportVisibility_check
branch
from
56cbb35 to
65aba15
Compare
FranzBusch
approved these changes
Dec 13, 2024
|
It appears this broke building with Swift 6.1 and 6.2 for linux and Android. It looks like choosing to import |
finagolfin
added a commit
to finagolfin/swift-android-sdk
that referenced
this pull request
Dec 15, 2024
|
Interesting, seems like it must have moved? |
|
See #185. |
Lukasa
added a commit
that referenced
this pull request
Dec 16, 2024
Motivation: It turns out that #183 broke the build on a number of platforms, including Linux 6.1+, Android 6.1+, and on 6.0 macOS. We need to keep things building. Modifications: Guard the import of CDispatch Remove the use of replacingOccurrences Result: Better builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable MemberImportVisibility check on all targets. Use a standard string header and footer to bracket the new block for ease of updating in the future with scripts.