Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Swift 5.5 #172

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Conversation

simonjbeaumont
Copy link
Contributor

@simonjbeaumont simonjbeaumont commented Apr 14, 2023

Motivation:

Now Swift 5.8 is released, we are dropping support for 5.5, in line with the usual support window.

Modifications:

  • Remove Package@swift-5.5.swift.
  • Remove #if swift(>=5.6) compiler guards.
  • Update documentation and README.

Result:

No functional change, but Swift 5.5 is no longer supported.

Signed-off-by: Si Beaumont <beaumont@apple.com>
README.md Outdated Show resolved Hide resolved
Sources/NIOTransportServices/Docs.docc/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo one nit

README.md Outdated Show resolved Hide resolved
Signed-off-by: Si Beaumont <beaumont@apple.com>
@simonjbeaumont simonjbeaumont marked this pull request as ready for review April 14, 2023 10:38
@Lukasa
Copy link
Contributor

Lukasa commented Apr 14, 2023

@swift-server-bot add to allowlist

@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label Apr 14, 2023
@simonjbeaumont
Copy link
Contributor Author

@yim-lee Please can we remove the 5.5 CI for this project?

@yim-lee
Copy link
Member

yim-lee commented Apr 14, 2023

Please can we remove the 5.5 CI for this project?

@simonjbeaumont Done

@Lukasa Lukasa merged commit dd408dc into apple:main Apr 14, 2023
@dnadoba dnadoba added 🔨 semver/patch No public API change. 🆕 semver/minor Adds new public API. and removed 🆕 semver/minor Adds new public API. 🔨 semver/patch No public API change. labels Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants