Async methods for NIOTSListenerBootstrap and NIOTSConnectionBootstrap
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rap` # Motivation We want to support async bootstrapping with all our bootstraps. # Modification This PR adds support for the `NIOTSListenerBootstrap` and `NIOTSConnectionBootstrap`. It also adds the three variants of methods to it (abstract output, `NIOAsyncChannel` based and protocol negotiation based) # Result We now support asynchronous interaction with the `NIOTSListenerBootstrap` and `NIOTSConnectionBootstrap`
Lukasa
reviewed
Jul 5, 2023
glbrntt
requested changes
Jul 5, 2023
|
@swift-server-bot add to allowlist |
glbrntt
approved these changes
Jul 5, 2023
glbrntt
approved these changes
Jul 6, 2023
Lukasa
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to support async bootstrapping with all our bootstraps.
Modification
This PR adds support for the
NIOTSListenerBootstrapandNIOTSConnectionBootstrap. It also adds the three variants of methods to it (abstract output,NIOAsyncChannelbased and protocol negotiation based)Result
We now support asynchronous interaction with the
NIOTSListenerBootstrapandNIOTSConnectionBootstrap