-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for connection viability updates #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, it seems like a useful addition.
Presumably we get a notification when a connection is established? If so it means we should be able to write a test that verifies we actually get the notification. Do you think you'd be able to add one? It looks like NIOTSEndToEndTests.swift
would be a good place to start.
… test to prove that we are receiving viability updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of small comments but this looks great otherwise
Co-authored-by: George Barnett <gbarnett@apple.com>
Co-authored-by: Cory Benfield <lukasa@apple.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thank you! @Lukasa did you want to look as well?
@swift-server-bot test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks @Cartisim!
Enhancement: Integration of Viability Handler in
Network.framework
We have successfully integrated the
viabilityUpdateHandler
fromNetwork.framework
intoNIOTransportServices
, enabling developers to leverage the full potential of theNetwork.framework
API.This enhancement provides adopters with critical insights into the viability of connections to remote endpoints. By being informed about the current network status, developers can implement a more responsive and adaptive approach to network behavior and conditions.
Modifications
Network.framework
handler.NIO
InboundEventsTriggered method, allowing consumers to respond to network changes effectively.Result
Clients can now receive viability events from
Network.framework
, enhancing their ability to manage network connections dynamically