Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ChannelHandler that closes Channel on unhandled error. #841

Closed
Lukasa opened this issue Feb 25, 2019 · 2 comments · Fixed by #967
Closed

Provide ChannelHandler that closes Channel on unhandled error. #841

Lukasa opened this issue Feb 25, 2019 · 2 comments · Fixed by #967
Labels
good first issue Good for newcomers

Comments

@Lukasa
Copy link
Contributor

Lukasa commented Feb 25, 2019

As we change #600, many users will start leaking Channels because they don't close on error. We should provide a ChannelHandler that closes on unhandled error that is typically added last to the pipeline.

@Lukasa Lukasa added the good first issue Good for newcomers label Feb 25, 2019
@allright
Copy link

allright commented Mar 7, 2019

I think this tickets are very similar:
#841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants