Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert hit on 32 bit machines #972

Closed
tgu opened this issue Apr 17, 2019 · 2 comments · Fixed by #978
Closed

Assert hit on 32 bit machines #972

tgu opened this issue Apr 17, 2019 · 2 comments · Fixed by #978
Labels
kind/bug Feature doesn't work as expected.

Comments

@tgu
Copy link

tgu commented Apr 17, 2019

swift-nio/Sources/NIO/CircularBuffer.swift

Line 83 in e32a436

assert(MemoryLayout.size(ofValue: self) == MemoryLayout<Int>.size)

@Lukasa
Copy link
Contributor

Lukasa commented Apr 17, 2019

Yes, that assertion seems somewhat bogus. @weissi this went in in #909, any reason for it?

@weissi
Copy link
Member

weissi commented Apr 17, 2019

@Lukasa I put that in during development and forgot to remove, apologies. We could probably could alter it to == MemoryLayout<Int64>.size

@weissi weissi mentioned this issue Apr 23, 2019
Merged
@weissi weissi added the kind/bug Feature doesn't work as expected. label Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CircularBuffer.Index: remove bogus assert weissi/swift-nio
3 participants
@tgu @weissi @Lukasa