CircularBuffer.Index: remove bogus assert #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: CircularBuffer.Index was asserting that its size is the same as a word. Whilst that's true on 64-bit architectures, the assert itself is bogus and a left-over from development. Modifications: Remove bogus assert. Result: Better 32-bit support.
tomerd
approved these changes
Apr 23, 2019
weissi
added a commit
to weissi/swift-nio
that referenced
this pull request
Apr 30, 2019
Motivation: CircularBuffer.Index was asserting that its size is the same as a word. Whilst that's true on 64-bit architectures, the assert itself is bogus and a left-over from development. Modifications: Remove bogus assert. Result: Better 32-bit support. (cherry picked from commit 2cfa777)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
CircularBuffer.Index was asserting that its size is the same as a word.
Whilst that's true on 64-bit architectures, the assert itself is bogus
and a left-over from development.
Modifications:
Remove bogus assert.
Result: