Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Websocket client upgrade failure #2659

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix for Websocket client upgrade failure #2659

wants to merge 4 commits into from

Commits on Feb 19, 2024

  1. Fix for Websocket client upgrade failure 

    Motivation:

Fix for issue-2631

Modifications:

Make sure the completion handler is sent on handler removed in upgrade failure path

Result:

Fix for both cases described in the issue.
    @agnosticdev
    agnosticdev committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7b57716 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into issue-2631

    @agnosticdev
    agnosticdev committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8997eb9 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Added unit test for notUpgradingCompletionHandler 

    Motivation:

Review team asked to add a unit test

Modifications:

Added a new unit test to WebSocketClientEndToEndTests

Result:

Test the change I made
    @agnosticdev
    agnosticdev committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7676593 View commit details
    Browse the repository at this point in the history

  2. Removed print 

    Motivation:

Random print statement left in
    @agnosticdev
    agnosticdev committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    5c3dc90 View commit details
    Browse the repository at this point in the history